fix: resolve CI lint errors and Docker build context mismatch#2
Merged
Conversation
Owner
psychic-coder
commented
May 22, 2026
psychic-coder
commented
- Fix Dockerfile COPY paths to be relative to build context (apps/backend/) so both CI (context: ./apps/backend) and docker-compose work correctly
- Update docker-compose backend build context to ./apps/backend/
- Downgrade unsafe-* TypeScript ESLint rules to 'warn' in eslint.config.mjs (GitHub API responses are untyped JSON - strict typing not practical here)
- Remove unused imports: RepoSize, NCFScoreBreakdown, RepoHealthFlags, SavedRepoStatus, User, and filtersRelaxed variable
- Prefix unused _repoDetails param in ncf-scorer.service.ts with _
- Rewrite ncf-scorer spec to use proper TypeScript types (unknown, RequestInfo, Response cast) eliminating all unsafe-any errors in test file
- Fix Dockerfile COPY paths to be relative to build context (apps/backend/) so both CI (context: ./apps/backend) and docker-compose work correctly - Update docker-compose backend build context to ./apps/backend/ - Downgrade unsafe-* TypeScript ESLint rules to 'warn' in eslint.config.mjs (GitHub API responses are untyped JSON - strict typing not practical here) - Remove unused imports: RepoSize, NCFScoreBreakdown, RepoHealthFlags, SavedRepoStatus, User, and filtersRelaxed variable - Prefix unused _repoDetails param in ncf-scorer.service.ts with _ - Rewrite ncf-scorer spec to use proper TypeScript types (unknown, RequestInfo, Response cast) eliminating all unsafe-any errors in test file
Replace url.toString() with explicit type-narrowing: typeof url === 'string' ? url : url instanceof URL ? url.href : url.url This safely handles all three cases of RequestInfo|URL without risking [object Object] stringification on a Request object.
The frontend Dockerfile COPYs from both apps/frontend/ and apps/backend/packages/ (shared-types). The context must be the repo root (.) so both paths are available to the builder. Backend context stays as ./apps/backend (self-contained).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.