Skip to content

[WRAPPER] Fix missing wrapper signatures#3690

Closed
runlevel5 wants to merge 3 commits intoptitSeb:mainfrom
runlevel5:fix-missing-wrapper-signatures
Closed

[WRAPPER] Fix missing wrapper signatures#3690
runlevel5 wants to merge 3 commits intoptitSeb:mainfrom
runlevel5:fix-missing-wrapper-signatures

Conversation

@runlevel5
Copy link
Contributor

  • pFiiiii — 5-arg wrapper referenced in lookup table but never defined
  • uFEv — wrapper for GOM(glGetError, uFEv) missing
  • wrappedlibgltypes.h — multiple GOM functions missing from the SUPER() macro

Add wrapper function declarations, typedefs, and implementations for
three signatures that were referenced but never defined, causing link
errors on PPC64LE builds:

- uFEv: uint32_t fn(x64emu_t*) — used by wrappedlibgl GOM(glGetError)
- uFEu: uint32_t fn(x64emu_t*, uint32_t) — used by wrappedlibgl
  GOM(glCheckFramebufferStatus)
- pFiiiii: void* fn(int32_t x5) — referenced in PPC64LE
  isSimpleWrapper lookup table
Add typedefs and SUPER() macro entries for four GOM functions in
wrappedlibgl that were declared in wrappedlibgl_private.h but missing
from the types header, causing libgl_my_t to lack those members:

- glGetError (uFv_t)
- glCheckFramebufferStatus (uFu_t)
- glCheckFramebufferStatusEXT (uFu_t)
- glStringMarkerGREMEDY (vFip_t)
Add debug trace formatting for the uFEu signature so BOX64_LOG=1
output shows readable argument values for uint32_t fn(emu, uint32_t)
calls (e.g. glCheckFramebufferStatus).
@ptitSeb
Copy link
Owner

ptitSeb commented Mar 20, 2026

What is this PR? It contains only generated files? Are generating the files automaticaly or are you touching it manualy (or with some AI assist)???

@ptitSeb
Copy link
Owner

ptitSeb commented Mar 20, 2026

So, there was some missing update from my previous commit (not sure how it happened, as I just pushed all the changes). It's fixed now, but I still don't understand how you are doing your pull request.

@runlevel5 runlevel5 closed this Mar 20, 2026
@runlevel5
Copy link
Contributor Author

So, there was some missing update from my previous commit (not sure how it happened, as I just pushed all the changes). It's fixed now, but I still don't understand how you are doing your pull request.

While I was trying to fix my own build, I was manually patching the file. I was trying rebuild_wrappers.py but it did not fix generated files (after upgrading to Fedora 44). Thanks for fixing this for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants