Enhance documentation for JSON loading methods and add exception handling in Iso6392Data, Iso6393Data, and Rfc5646Data classes; add tests for LanguageTag parsing and normalization with options; implement logging options tests.#71
Conversation
…ling in Iso6392Data, Iso6393Data, and Rfc5646Data classes; add tests for LanguageTag parsing and normalization with options; implement logging options tests.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the LanguageTags library by improving documentation and adding comprehensive test coverage for the logging options functionality. The changes ensure that the Options parameter overloads for parsing and normalization methods are properly tested, and the XML documentation for data loading methods is more accurate and helpful.
Changes:
- Added comprehensive test coverage for LogOptions class with 8 new tests covering logger factory and logger configuration scenarios
- Added test coverage for Options parameter overloads in LanguageTag parsing, TryParse, ParseAndNormalize, and LanguageTagBuilder.Normalize methods
- Enhanced XML documentation for LoadJsonAsync methods in Iso6392Data, Iso6393Data, and Rfc5646Data to document IOException and JsonException exceptions and clarify return value semantics
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| LanguageTagsTests/LogOptionsTests.cs | New test file with 8 comprehensive tests for LogOptions functionality covering factory/logger configuration and fallback behavior |
| LanguageTagsTests/LanguageTagTests.cs | Added tests for Parse, TryParse, and ParseAndNormalize methods with Options parameter |
| LanguageTagsTests/LanguageTagBuilderTests.cs | Added test for Normalize method with Options parameter |
| LanguageTagsTests/Fixture.cs | Added DisableParallelDefinition collection to ensure LogOptions tests don't run in parallel (preventing test interference) |
| LanguageTags/Iso6392Data.cs | Enhanced LoadJsonAsync documentation with exception tags and clarified return value description |
| LanguageTags/Iso6393Data.cs | Enhanced LoadJsonAsync documentation with exception tags and clarified return value description |
| LanguageTags/Rfc5646Data.cs | Enhanced LoadJsonAsync documentation with exception tags and clarified return value description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.