Conversation
…alization and ordering using StringComparer.Ordinal.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the string sorting behavior in language tag normalization by making the culture-independent sorting explicit. Previously, the OrderBy operations used the default comparer which is culture-dependent; now they explicitly use StringComparer.Ordinal.
Changes:
- Added explicit
StringComparer.Ordinalto sorting operations inExtensionTag.Normalize()andPrivateUseTag.Normalize()methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the LanguageTags library with improved encapsulation, asynchronous operations, and logging capabilities. Update various dependencies, including actions and nuget packages, while also refining documentation and adding tests for new functionalities. Address issues related to husky installation and improve error handling in language tag processing.