Skip to content

[WIP] Fix issues based on review feedback for pull request 279#281

Merged
ptr727 merged 2 commits intodevelopfrom
copilot/sub-pr-279-again
Jan 4, 2026
Merged

[WIP] Fix issues based on review feedback for pull request 279#281
ptr727 merged 2 commits intodevelopfrom
copilot/sub-pr-279-again

Conversation

Copy link
Contributor

Copilot AI commented Jan 4, 2026

  • Make HttpClient timeout configurable via a public property
  • Set default timeout to 180 seconds (current value)
  • Add XML documentation for the timeout property
  • Build and verify changes work correctly
  • Run code review and security checks

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Jan 4, 2026
@ptr727 ptr727 marked this pull request as ready for review January 4, 2026 03:35
Copilot AI review requested due to automatic review settings January 4, 2026 03:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
@ptr727 ptr727 merged commit 8b1993e into develop Jan 4, 2026
2 checks passed
Copilot AI requested a review from ptr727 January 4, 2026 03:38
ptr727 added a commit that referenced this pull request Jan 4, 2026
* Bump the nuget-deps group with 3 updates

Bumps csharpier from 1.1.1 to 1.1.2
Bumps xunit.analyzers from 1.23.0 to 1.24.0
Bumps xunit.runner.visualstudio from 3.1.3 to 3.1.4

---
updated-dependencies:
- dependency-name: csharpier
  dependency-version: 1.1.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget-deps
- dependency-name: xunit.analyzers
  dependency-version: 1.24.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: nuget-deps
- dependency-name: xunit.runner.visualstudio
  dependency-version: 3.1.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump the nuget-deps group with 1 update

Bumps xunit.runner.visualstudio from 3.1.4 to 3.1.5

---
updated-dependencies:
- dependency-name: xunit.runner.visualstudio
  dependency-version: 3.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump csharpier from 1.1.2 to 1.2.1

---
updated-dependencies:
- dependency-name: csharpier
  dependency-version: 1.2.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: nuget-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Serilog.Sinks.Console from 6.0.0 to 6.1.1

---
updated-dependencies:
- dependency-name: Serilog.Sinks.Console
  dependency-version: 6.1.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: nuget-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update dependencies

* Bump the nuget-deps group with 1 update

Bumps csharpier from 1.2.1 to 1.2.3

---
updated-dependencies:
- dependency-name: csharpier
  dependency-version: 1.2.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump the actions-deps group across 1 directory with 2 updates (#270)

Bumps the actions-deps group with 2 updates in the / directory: [actions/setup-dotnet](https://github.com/actions/setup-dotnet) and [actions/checkout](https://github.com/actions/checkout).


Updates `actions/setup-dotnet` from 4 to 5
- [Release notes](https://github.com/actions/setup-dotnet/releases)
- [Commits](actions/setup-dotnet@v4...v5)

Updates `actions/checkout` from 5 to 6
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-dotnet
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions-deps
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions-deps
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the nuget-deps group with 1 update

Bumps csharpier from 1.2.3 to 1.2.4

---
updated-dependencies:
- dependency-name: csharpier
  dependency-version: 1.2.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump the nuget-deps group with 1 update

Bumps csharpier from 1.2.4 to 1.2.5

---
updated-dependencies:
- dependency-name: csharpier
  dependency-version: 1.2.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: nuget-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* .NET 10 and AOT support

* Build pipeline also needs to be 10.0

* gitignore

* rider

* [WIP] Update changes based on feedback from pull request #279 (#280)

* Initial plan

* Add using statement and simplify CallerMemberName attributes

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* [WIP] Fix issues based on review feedback for pull request 279 (#281)

* Initial plan

* Make HttpClient timeout configurable via TimeoutSeconds property

Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>

* Update UtilitiesTests/DownloadAsyncTests.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* [WIP] WIP address feedback from review on 'Develop' pull request (#283)

* Initial plan

* Replace redundant ToString() with string interpolation in FileExAsyncTests

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* [WIP] Address feedback from review on pull request #279 (#282)

* Initial plan

* Replace explicit ToString() calls with string interpolation

Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>

* Initial plan (#284)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* Initial plan (#285)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ptr727 <2061579+ptr727@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ptr727 ptr727 deleted the copilot/sub-pr-279-again branch January 4, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments