Require that hubs respond with a hub.lease_seconds.#17
Merged
Conversation
julien51
added a commit
that referenced
this pull request
Jun 8, 2012
Require that hubs respond with a hub.lease_seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because now all subscriptions are ephemeral the hub should respond with a hub.lease_seconds on every subscription.
At some point we should add an appendix with best practices to suggest that hubs should have both a min_lease_seconds and max_lease_seconds. I noticed that pubsubhubbub.appspot.com does not have a min_lease_seconds which is bad. A malicious user can subscribe lots of endpoints (which are on another site) with lease_seconds = 1 which might end up with a hub performing a DOS attach on the target site. That's not cool :-)