-
Notifications
You must be signed in to change notification settings - Fork 0
Update audioaip #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update audioaip #10
Conversation
This changes the process slightly so that if more than one WAV file is present for a tape (ex. Side A and Side B) that both are packaged as part of a single AIP for each audio tape. I also changed the data integrity verification from manifest-md5 to manifest-sha256 to improve security.
|
@privatezero I was pulling some code from other places, so not sure if the way I did this is how you'd prefer it to be. But I can confirm it's working on my end. |
|
The only issue that I am seeing is that I get "bagit: error: unrecognized arguments: --excludehiddenfiles" but the AIPs are packaged as expected and pass verification checks. is it supposed to be "--exclude-hidden-files" |
|
Don't have time to test run this rn, but if it is working for you in terms of outputs, then it's probably working fine! My thoughts are more around some of the assumptions in the scripts that might be a little out of date:
|
|
Also - you saw my comments on sha256 vs md5 on the other issue I think, but worth thinking about what is useful there for you and your partners |
I'll default to what you think it best for sure and what's the best practice currently. I think I'd prefer to stick with md5 especially since that's your recommendation :) |
you are correct! |
|
corrected the checksum situation
|
@privatezero lemme know if you think any other changes should be made to this before merging :) |
This changes the process slightly so that if more than one WAV file is present for a tape (ex. Side A and Side B) that both are packaged as part of a single AIP for each audio tape. I also changed the data integrity verification from manifest-md5 to manifest-sha256 to improve security.
@privatezero let me know what you think!