Moved the rest of Puli\Manager\Api\Package to Puli\Manager\Api\Module #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did also fix the old rename of Puli => Container
Fixed failing tests
Member
Author
|
Tests are failing because of puli/issues#198. Could this be merged before the versioning if fixed? |
Member
Author
|
I make sure to skip the tests that are failing because of puli/issues#198. Is this acceptable? |
Member
|
I'd prefer if you remove the skip so that we don't forget about this. We can merge this anyway. |
Member
Author
|
Okey. Thank you. |
Member
Author
|
I've updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did also fix the old rename of Puli => Container