Skip to content

Extend HCI with ECC#39

Closed
LuigiGhionda wants to merge 22 commits intomasterfrom
lg/ecc_rebase
Closed

Extend HCI with ECC#39
LuigiGhionda wants to merge 22 commits intomasterfrom
lg/ecc_rebase

Conversation

@LuigiGhionda
Copy link
Contributor

@LuigiGhionda LuigiGhionda commented Jun 3, 2024

This PR extends HCI with ECC introducing:

  1. Dedicated encoder and decoder for the HCI payload signals based on SEC-DED encoding
  2. ECC-extended HWPE streamer modules
  3. ECC-extended interconnect module
  4. Memory-mapped error-counting registers to collect statistics

This PR supersedes and extends #25 .

Luigi Ghionda and others added 17 commits May 31, 2024 16:49
@LuigiGhionda
Add HCI ECC encoder and decoder modules
757d93f
@LuigiGhionda
Add HCI ECC source and sink modules
a27fba9
@LuigiGhionda
Add HCI ECC interconnect module
960f979
@LuigiGhionda
Fix ecc signals propagation
4373bad
@LuigiGhionda
Add memory-mapped registers to store the number of detected errors on…
1344fb7 
… interconnect-side
@LuigiGhionda
Add option to bypass data encoding/decoding if only metadata encoding…
f45da86 
…/decoding is needed
@LuigiGhionda
Update interconnect to support ECC extension up to the memory side
236c5ef 
* Introduce additional encoders/decoders along the interconnect to properly handle ECC bits across the different modules
* Add router and arbiter modules able to properly handle ECC bits
@LuigiGhionda
Add error signaling to ECC encoder
e702654
@LuigiGhionda
Redesign memory-mapped error-counting registers
c4d1693
@LuigiGhionda
Remove unused signals
9f34aa2
@LuigiGhionda
Small fix
4e49eee
@LuigiGhionda
Modify to record detected errors on r_data only when the data is valid
b6b2188
@LuigiGhionda
Add error signaling to ECC source module
f7ecd0e
@LuigiGhionda
Remove periph_to_reg module from inside the ecc_manager to not be bou…
bf0067b 
…nd by the slave port type
@LuigiGhionda
Update authors
9aafa39
@LuigiGhionda
Remove the dedicated router and router_reorder modules and instead mo…
b513954 
…dify the original modules accordingly

Initially, dedicated modules were introduced for simplicity. However, to avoid adding unnecessary files, they have now been removed and merged with the original modules
@LuigiGhionda
Small cleanup
47a4ec1
Lynx005F
Lynx005F reviewed Jun 17, 2024
View reviewed changes
@LuigiGhionda
Fix typo
e0db5f6
@LuigiGhionda
Remove r_opc signal from the encoding since it's not used at the moment
04e90e7
@LuigiGhionda
Change the minimum value of UW to encode also the user/r_user signal
46e1563 
UW default value is now 1 instead of 0
@LuigiGhionda
Merge branch 'lg/new_meta_enc' into lg/ecc_rebase
97c8d93 
Remove r_opc signal from the encoded signals and change parametrization for user signal
@LuigiGhionda
Fix errors exposure
2d6d5df 
* Errors on data are evaluated on read valid
* Errors on metadata are evaluated on successful handshake
@LuigiGhionda LuigiGhionda marked this pull request as draft July 4, 2024 06:38
@LuigiGhionda LuigiGhionda mentioned this pull request Jul 4, 2024
Closed
@LuigiGhionda
Copy link
Contributor Author

LuigiGhionda commented Jul 4, 2024

Closing as there is a rebased version #43

@sermazz sermazz mentioned this pull request Mar 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FrancescoConti FrancescoConti Awaiting requested review from FrancescoConti

1 more reviewer

@Lynx005F Lynx005F Lynx005F left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LuigiGhionda @Lynx005F

Comments