Skip to content

Small quality-of-life fixes#45

Merged
FrancescoConti merged 1 commit intoastralfrom
fc/qol-fixes
Apr 16, 2024
Merged

Small quality-of-life fixes#45
FrancescoConti merged 1 commit intoastralfrom
fc/qol-fixes

Conversation

@FrancescoConti
Copy link
Member

  1. enable compilation without cleaning by overwriting the (anyways broken!)
    modelsim.ini, etc. files on symlink creation
  2. work out-of-the-box on non-ETH machines by not defining the QUESTA
    env var
  3. make run dependent on $(TARGETS) being built

@FrancescoConti FrancescoConti requested a review from ricted98 March 5, 2024 23:16
@ricted98
Copy link
Contributor

ricted98 commented Mar 6, 2024

The changes looks good. However, as we bump the runtime for the cluster the TCL scripts used to run the simulation must be tweaked. In particular, in this line and this line the APP variable must be set to test/test since we are already executing in build.

@yvantor yvantor self-requested a review March 6, 2024 08:24
@yvantor
Copy link
Contributor

yvantor commented Mar 6, 2024

Looks good!

@yvantor
Copy link
Contributor

yvantor commented Mar 6, 2024

The changes looks good. However, as we bump the runtime for the cluster the TCL scripts used to run the simulation must be tweaked. In particular, in this line and this line the APP variable must be set to test/test since we are already executing in build.

Does it break if we merge?

@ricted98
Copy link
Contributor

ricted98 commented Mar 6, 2024

We should not break the cluster as long as we do not update the commit we are referencing in the submodule for the pulp-runtime. And then we need to update the TCL scripts.

@FrancescoConti
Copy link
Member Author

I think it's easier to fix these small things directly in this branch before merging the PR. I will take a look

@ricted98
Copy link
Contributor

ricted98 commented Mar 6, 2024

We might have to set up a dedicated PR on the cluster in parallel to implement the fixes I suggested before.

@bluewww
Copy link
Collaborator

bluewww commented Mar 6, 2024

It's better to check if /etc/iis.version exists to determine whether it is an ETH machine that doing some hostname grepping thing

1) enable compilation without cleaning by overwriting the (anyways broken!)
   modelsim.ini, etc. files on symlink creation
2) work out-of-the-box on non-ETH machines by not defining the QUESTA
   env var
3) make run dependent on $(TARGETS) being built
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments