Merged
Conversation
Contributor
Contributor
|
Looks good! |
Contributor
Contributor
|
We should not break the cluster as long as we do not update the commit we are referencing in the submodule for the pulp-runtime. And then we need to update the TCL scripts. |
Member
Author
|
I think it's easier to fix these small things directly in this branch before merging the PR. I will take a look |
Contributor
|
We might have to set up a dedicated PR on the cluster in parallel to implement the fixes I suggested before. |
Collaborator
|
It's better to check if |
1) enable compilation without cleaning by overwriting the (anyways broken!) modelsim.ini, etc. files on symlink creation 2) work out-of-the-box on non-ETH machines by not defining the QUESTA env var 3) make run dependent on $(TARGETS) being built
d984faa to
e3a8142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modelsim.ini, etc. files on symlink creation
env var