Use build instead of deprecated setup.py #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for PEP625 was added in setuptools 69.3.0. There is also a fix for name normalization in 70.2.0.
The generated clients generates pyproject and setup.py files, but it doesnt specifiy the required setuptools version.
I suspect it could possibly be using a setuptools version for the build which doesnt know how to generate the normalized names.
Furthermore, we were building the client using
python setup.py, which is deprecated for quite some time now. Just switcthing to usepython -m buildfixed the name. Possiblybuilduses a more appropriate setuptools version.Also opened a pulp-openapi-generator PR to test, but just replacing
python setup.pyseems to do the trick.