[PULP-1029] Fix header access for urllib3 2.6 in v4.3.1 python #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjust urllib3 requirement for not using semver.
jobselko
reviewed
Dec 8, 2025
| {{#-last}} | ||
| REQUIRES = [ | ||
| "urllib3 >= 1.25.3, < 3.0.0", | ||
| "urllib3 >= 1.25.3, < 2.7", |
There was a problem hiding this comment.
2.6.0 is problematic, so it should be <2.6
Member
Author
There was a problem hiding this comment.
I fixed the problematic part (hopefully) in the v4.3.1 directory where it happens. (That is BTW the reason why it only happens on certain lb runs where the pulpcore version is < 3.70.)
But I still decided to correct the upper bound here, because urllib3 certainly does not use semver.
ggainey
approved these changes
Dec 8, 2025
Contributor
ggainey
left a comment
ggainey
left a comment
There was a problem hiding this comment.
Approving, knowing that only the first CI-run that uses this is really going to tell us if this Fixes Things or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adjust urllib3 requirement for not using semver.