Skip to content

Problem: ruby client can't form-encode PUT requests#21

Merged
dkliban merged 1 commit intopulp:masterfrom
dkliban:use-jar-for-ruby
Jul 24, 2019
Merged

Problem: ruby client can't form-encode PUT requests#21
dkliban merged 1 commit intopulp:masterfrom
dkliban:use-jar-for-ruby

Conversation

@dkliban
Copy link
Member

@dkliban dkliban commented Jul 23, 2019

Solution: switch ruby client to use Faraday

This patch relies on a forked version of the openapi-generator-cli. Once the PR that
introduces this functionality is merged into openapi-generator, the ruby client
generation should be switched back to using the docker container for openapi-generator.

OpenAPITools/openapi-generator#3405

Required PR: pulp/pulpcore#226

re: #4896
https://pulp.plan.io/issues/4896

@dkliban dkliban force-pushed the use-jar-for-ruby branch 5 times, most recently from 8fceac6 to bfc0ce7 Compare July 23, 2019 18:12
Solution: switch ruby client to use Faraday

This patch relies on a forked version of the openapi-generator-cli. Once the PR that
introduces this functionality is merged into openapi-generator, the ruby client
generation should be switched back to using the docker container for openapi-generator.

OpenAPITools/openapi-generator#3405

Required PR: pulp/pulpcore#226

re: #4896
https://pulp.plan.io/issues/4896
@dkliban dkliban force-pushed the use-jar-for-ruby branch from bfc0ce7 to 028b333 Compare July 23, 2019 19:08
Copy link
Contributor

@daviddavis daviddavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkliban dkliban merged commit 44383d2 into pulp:master Jul 24, 2019
@dkliban dkliban deleted the use-jar-for-ruby branch July 24, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants