Problem: bindings break all the time#85
Merged
dkliban merged 1 commit intopulp:masterfrom Apr 15, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 65.66% 65.69% +0.03%
==========================================
Files 65 65
Lines 3017 3017
==========================================
+ Hits 1981 1982 +1
+ Misses 1036 1035 -1
Continue to review full report at Codecov.
|
Member
Author
|
These bindings only work on Python < 3.7 for now. We are experiencing a known bug[0]. There is already a patch on the master branch of swagger-codegen. |
daviddavis
approved these changes
Apr 15, 2019
bmbouter
reviewed
Apr 15, 2019
Solution: build and test bindings continuosly This patch adds another job to the Travis build matrix. This new build installs pulpcore and pulp_file and then builds a client library for each. The client libraries are built using pulp-swagger-codegen, a thin wrapper around swagger-codegen-cli. After building the bindings, this job installs them and runs a script that performs the following: - Create a File Remote - Create a Repository - Sync a Repository - Monitor the sync task - Create an artifact from a local file - Create a FileContent from the artifact - Add the new FileContent to a repository version - Monitor the repo version creation task - Create a FilePublisher - Create a publication from the latest version of the repository - Monitor the publish task - Create a distribution pointint to the publication fixes: pulp#4123 https://pulp.plan.io/issues/4123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: build and test bindings continuosly
This patch adds another job to the Travis build matrix. This new build installs pulpcore and pulp_file
and then builds a client library for each. The client libraries are built using pulp-swagger-codegen,
a thin wrapper around swagger-codegen-cli. After building the bindings, this job installs them and runs
a script that performs the following:
fixes: #4123
https://pulp.plan.io/issues/4123