fix: wide-arithmetic, SIMD store lane, GC ops, linking, memory imports#159
Merged
fix: wide-arithmetic, SIMD store lane, GC ops, linking, memory imports#159
Conversation
Wide-arithmetic (101→109/109 passing): - Add i64.add128, i64.sub128, i64.mul_wide_s, i64.mul_wide_u instructions - Fix 0xFC sub-opcode reading to use LEB128 (spec-correct) SIMD store lane (0→128/128 passing): - Fix GlobalWrapper serialization to handle V128 (16 bytes vs 8) - Fix global init expression parser for 0xFD/0xFC/0xFB prefixed opcodes - Fix local variable zero-initialization for V128/ref types GC validator + table ops: - Fix ref.eq/ref.as_non_null/br_on_null/br_on_non_null opcode assignments - Add GC ref type support in table.set/get/grow/fill - Fix ref.null to push correct GC bottom types in validator - Add relaxed SIMD opcode classification in validator - Fix element segment expression parsing for ref.i31 - Implement general-purpose constant expression evaluator for elem init Linking + memory imports (memory_grow: 0→51/51 passing): - Add resolve_registered_memory_imports for cross-module memory sharing - Fix mutable global import sharing (Arc<RwLock> not copy) - Implement WastExecute::Wat handling - Execute start functions during module loading WAST conformance: 62,788 → 63,405 passed (+617), 2,854 → 2,237 failed. Trace: skip Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo checkpassesTrace: skip
🤖 Generated with Claude Code