fix(decoder): SIMD lane byte range and GC code body parsing (#150)#171
Merged
fix(decoder): SIMD lane byte range and GC code body parsing (#150)#171
Conversation
…t 14-21) Subops 14-20 (i8x16.swizzle and *_splat) have NO immediates, but the code body validator was consuming a lane byte for them. The actual extract_lane/replace_lane ops that need a lane byte are subops 21-34. Fixes 44 more WAST assertions (simd_splat.wast: 185/185 now passing). Trace: skip Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🔍 Build Diagnostics ReportSummary
🎯 Impact AnalysisIssues in Files You Modified
Cascading Issues (Your Changes Breaking Other Files)
✅ No Issues DetectedPerfect! Your changes don't introduce any new errors or warnings, and don't break any existing code. 📊 Full diagnostic data available in workflow artifacts 🔧 To reproduce locally: # Install cargo-kiln
cargo install --path cargo-kiln
# Analyze your changes
cargo-kiln build --output json --filter-severity error
cargo-kiln check --output json --filter-severity warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Baseline: 65,113 pass / 529 fail (after PR #170)
After: 65,157 pass / 485 fail (+44 assertions fixed)
Cumulative from original baseline: 64,068 to 65,157 (+1,089 assertions, -69% failures)
Test plan