fix: reject multiply-instantiated modules in resolver#76
Merged
Conversation
The merger already rejects multiply-instantiated modules, but the resolver runs first and silently builds a corrupt module_to_instance HashMap (last-write-wins). Add early detection in resolve_via_instances before the map is constructed, so the error is caught at the earliest pipeline stage. Closes #24. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_via_instances, before themodule_to_instanceHashMap is built (which silently drops duplicates via last-write-wins)check_no_duplicate_instantiations, but the resolver runs first and would produce a corrupted dependency graphDuplicateModuleInstantiationerror variant for consistent error messagesCloses #24
Test plan
test_multiply_instantiated_module_rejected— verifies duplicate module instantiation is caught with correct error messagetest_distinct_module_instantiations_accepted— verifies distinct modules pass validationtest_duplicate_module_instantiation_rejected,test_single_instantiation_accepted,test_no_instances_accepted) still pass🤖 Generated with Claude Code