Context
Branch feat/document-embeds has Tasks 1-3 committed (3 commits). Tasks 4-6 remain.
Spec: docs/superpowers/specs/2026-03-29-document-embeds-design.md (on docs/specs-and-plans branch)
Plan: docs/superpowers/plans/2026-03-29-embed-phase1.md
Completed (on branch)
Remaining
After Tasks 4-6
- Run full test suite (
cargo test && cargo clippy)
- Squash commits and recommit in main checkout (worktree pre-commit hooks broken)
- Create PR
- Add Playwright E2E tests for embeds in documents
Key files
rivet-core/src/embed.rs — parser, resolver, renderers
rivet-core/src/document.rs — refactored render_to_html with embed_resolver closure
rivet-cli/src/render/documents.rs — passes embed resolver to render_to_html
rivet-core/src/export.rs — placeholder resolver (Task 5 adds provenance)
Context
Branch
feat/document-embedshas Tasks 1-3 committed (3 commits). Tasks 4-6 remain.Spec:
docs/superpowers/specs/2026-03-29-document-embeds-design.md(ondocs/specs-and-plansbranch)Plan:
docs/superpowers/plans/2026-03-29-embed-phase1.mdCompleted (on branch)
EmbedRequestparser + error types (7 tests) — commit3f24ad5e69d0d3render_to_htmlwithembed_resolverclosure (2 tests) — commit71595c4sudo kill -9 $(pgrep syspolicyd)Remaining
rivet embedCLI command —Command::Embedvariant,cmd_embed()handler (3 tests)After Tasks 4-6
cargo test && cargo clippy)Key files
rivet-core/src/embed.rs— parser, resolver, renderersrivet-core/src/document.rs— refactoredrender_to_htmlwithembed_resolverclosurerivet-cli/src/render/documents.rs— passes embed resolver torender_to_htmlrivet-core/src/export.rs— placeholder resolver (Task 5 adds provenance)