chore: drop rules_rust git_override, adopt bazel_dep 0.70.0#466
Merged
Conversation
rules_rust 0.70.0 (released 2026-04-22) contains the .rmeta sysroot fix (#3860, merged 2026-02-23) and the rustc_lib filegroup fix (#3727, merged 2026-03-07) that the git_override was carrying for Windows LNK1181 missing-rlib errors. The pinned override commit 6281d27 is a strict ancestor of the 0.70.0 tag (compare: 0.70.0 is 56 ahead, 0 behind), so 0.70.0 fully contains the override's content. Removes the git_override and bumps bazel_dep rules_rust 0.69.0 -> 0.70.0, restoring a clean BCR dependency and resolving the override's own TODO. Validated: //examples/basic/... builds cleanly on macOS with 0.70.0 (210 actions, 0 errors). Windows LNK1181 behavior is exercised by CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avrabe
force-pushed
the
chore/rules-rust-0.70.0
branch
from
48fc3e9 to
8f8ac07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MODULE.bazelpinnedrules_rustto agit_override(commit6281d27) topick up two unreleased fixes for Windows LNK1181 missing-rlib errors. Its own
TODOsaid to remove it "once 0.70.0 is released with #3727 included".That release happened — 0.70.0 shipped 2026-04-22:
#3860(.rmetasysroot glob) merged 2026-02-23#3727(rustc_lib filegroup) merged 2026-03-07 — its merge commit is theoverride's pinned
6281d27Verified the override commit is fully contained in the release:
compare/6281d27...0.70.0→ 0 behind, 56 ahead (strict ancestor).Change
git_overridebazel_deprules_rust0.69.0→0.70.0MODULE.bazel.lockregeneratedValidation
//examples/basic/...builds cleanly on macOS with 0.70.0 (210 actions, 0errors). The Windows LNK1181 path that motivated the override is exercised by
the Windows CI job on this PR.
🤖 Generated with Claude Code