Skip to content

(CONT-1215) - Fix formatting for pdksync:show_config#189

Merged
GSPatton merged 2 commits intomainfrom
CONT-1215-fix_show_config_formatting
Jul 11, 2023
Merged

(CONT-1215) - Fix formatting for pdksync:show_config#189
GSPatton merged 2 commits intomainfrom
CONT-1215-fix_show_config_formatting

Conversation

@jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Jul 11, 2023

Fixes an issue where the formatting for show_config was off. (see additional context)
We do this by opting for the native methods already present in pdksync, rather than having an unnecessary dependency on a 3rd party gem.

Additional Context

image

Related Issues (if any)

Fixes #161.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.
    manual verification:
image

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner July 11, 2023 11:32
@jordanbreen28 jordanbreen28 force-pushed the CONT-1215-fix_show_config_formatting branch from d0ec3fd to 5c3867f Compare July 11, 2023 11:33
@jordanbreen28 jordanbreen28 force-pushed the CONT-1215-fix_show_config_formatting branch from 5c3867f to 1d1e5d5 Compare July 11, 2023 12:20
@GSPatton GSPatton merged commit 7379c0c into main Jul 11, 2023
@GSPatton GSPatton deleted the CONT-1215-fix_show_config_formatting branch July 11, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pdksync:show_config has unexpected output

2 participants