Improve module validation performance#193
Merged
jordanbreen28 merged 1 commit intopuppetlabs:mainfrom Jul 14, 2023
Merged
Conversation
Validate that each module exists only once, as that module is being processed.
|
|
jordanbreen28
approved these changes
Jul 14, 2023
Contributor
jordanbreen28
left a comment
jordanbreen28
left a comment
There was a problem hiding this comment.
@seanmil This is great! 💯
I'll merge if tests are green, this is a mega improvement. Thank you :-)
Contributor
|
Pulled and manually verified! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate that each module exists only once, as that module is being processed.
Summary
During module cloning, the module validation function is called for all modules on each iteration
through the module list, resulting in the cloning taking much longer than it needs to.
This change adjusts the code to validate one module at a time as that module is being
processed.
Checklist