Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 47.86% 47.86%
=======================================
Files 10 10
Lines 1220 1220
=======================================
Hits 584 584
Misses 636 636 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
3a00b23 to
a6c2591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds setup instruction that will work for modules or gems that require puppetcore (puppet or facter). These instructions are backward compatible. Since most repositories/modules are not yet puppetcore enabled, the
pdksyncshould work as before; however, as more and more become linked to puppetcore then these instructions will enable the seamless operation.Since puppet and facter are not included in either the gemspec or Gemfile, then only a doc change here is required.