Skip to content

Add puppetcore enablement instruction#227

Merged
LukasAud merged 1 commit intomainfrom
add_puppetcore
Apr 1, 2025
Merged

Add puppetcore enablement instruction#227
LukasAud merged 1 commit intomainfrom
add_puppetcore

Conversation

@gavindidrichsen
Copy link
Contributor

@gavindidrichsen gavindidrichsen commented Mar 25, 2025

Summary

This PR adds setup instruction that will work for modules or gems that require puppetcore (puppet or facter). These instructions are backward compatible. Since most repositories/modules are not yet puppetcore enabled, the pdksync should work as before; however, as more and more become linked to puppetcore then these instructions will enable the seamless operation.

Since puppet and facter are not included in either the gemspec or Gemfile, then only a doc change here is required.

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.86%. Comparing base (8cb5725) to head (a6c2591).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   47.86%   47.86%           
=======================================
  Files          10       10           
  Lines        1220     1220           
=======================================
  Hits          584      584           
  Misses        636      636           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
@gavindidrichsen gavindidrichsen marked this pull request as ready for review April 1, 2025 08:53
@gavindidrichsen gavindidrichsen requested review from a team and logicminds as code owners April 1, 2025 08:53
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 5c4ba9b into main Apr 1, 2025
5 checks passed
@LukasAud LukasAud deleted the add_puppetcore branch April 1, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants