(CAT-2327) Temporary revert of cache changes #378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following an escalation on resource_api, other teams are experiencing blockers due to changes made to cache behaviour in between 1.9.0 and 2.0.0. We are reverting any changes made in between those versions for a quick release.
This commit fixes multiple test failures related to excessive provider get calls by enhancing the caching mechanism in rsapi_provider_get method. The key improvements are: - When the cache already has all instances and specific resources are requested, filter from the cache instead of calling the provider - For simple_get_filter providers, use cached resources when available rather than calling get unnecessarily - Maintain proper cache state tracking to ensure consistent behavior These changes ensure that providers are called the minimum number of times necessary, which fixes the failing tests in get_calls_spec.rb, simple_get_filter_spec.rb and related tests. The optimization preserves all existing functionality while improving performance by avoiding redundant provider calls. Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
LukasAud
force-pushed
the
CAT-2327-Temporary_revert_of_cache_changes
branch
4 times, most recently
from
fbd1b3a to
2a22428
Compare
Contributor
Author
|
This is the command used for reverting: |
Contributor
Author
|
Outdated. No longer relevant. |
Contributor
|
@LukasAud we had to revert puppet-agent packages back to resource-api 1.9 due to a regression in the 2.0 version. https://github.com/puppetlabs/puppet-agent-private/commit/d57e065774d0d16c65e522ff59e41345cf05c4cb Is there another ticket/PR for fixing the regression so that we can unpin in the future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following an escalation on resource_api, other teams are experiencing blockers due to changes made to cache behaviour in between 1.9.0 and 2.0.0. We are reverting changes related to cache management made in between those versions for a quick release.
The core of this change is the reversion of the file resource_api.rb to its 1.9.0 state. The goal is to have a hotfix ready for a release if needed. This PR should be reverted after release and main branch code revisited for conflicts with PE behaviour.