Docker module doesn't work in AmazonLinux2

[karthik-jaganathan]

Describe the Bug

The Docker module is not working in AmazonLinux2 ARM hosts. There is a validation in the init.pp , it checks for RHEL >= 7. However, AmazonLinux2 VERSION has value of 2 so the above conditional check fails and module execution is exiting

NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"

Expected Behavior

Docker module should support all RHEL/Debian flaours

Steps to Reproduce

Steps to reproduce the behavior:

1. Refer here for the validation

   puppetlabs-docker/manifests/init.pp

   Line 479 in fc06928

   fail('This module only works on Debian, Red Hat or Windows based systems.')

Environment

• Version [Docker version 20.10.25, build b82b9f3]
• Platform [AmazonLinux2 ARM x86_64]

Additional Context

Add any other context about the problem here.

[rjd1]

Encountered the same issue recently and created a PR to address it. This change adds an exception to the RedHat 7 check for Amazon and another check below to fail if not Amazon Linux 2 or newer, effectively maintaining the same compatibility standard for that distribution.

[vikasperi]

Having the same issue.

[owenbeckles]

Having a similar issue with Amazon Linux 2023 while trying to install cd4pe on my test env - the puppetlabs-docker module is hard-coding the wrong url while trying to install the repo

It seems this is what's causing the issue

puppetlabs-docker/manifests/params.pp

Line 212 in cabba05

$package_ce_source_location = "https://download.docker.com/linux/rhel/${facts['os']['release']['major']}/${facts['os']['architecture']}/${docker_ce_channel}"