remove dependency on cgroupfs-mount for Debian trixie#1024
remove dependency on cgroupfs-mount for Debian trixie#1024span786 merged 1 commit intopuppetlabs:mainfrom
Conversation
|
|
manifests/params.pp
Outdated
| $prerequired_packages = $facts['os']['family'] ? { | ||
| 'Debian' => $facts['os']['name'] ? { | ||
| 'Debian' => ['cgroupfs-mount',], | ||
| 'Debian' => $facts['os']['distro']['codename'] ? { 'bookworm' => ['cgroupfs-mount',], 'trixie' => [] }, |
There was a problem hiding this comment.
| 'Debian' => $facts['os']['distro']['codename'] ? { 'bookworm' => ['cgroupfs-mount',], 'trixie' => [] }, | |
| 'Debian' => $facts['os']['distro']['codename'] ? { | |
| 'trixie' => [], | |
| default => ['cgroupfs-mount',], | |
| }, |
There was a problem hiding this comment.
Hello, @charlyforot, and thanks for the suggestion!
As i don't see the cgroupfs-mount package available in sid (ref), i suggest we keep a default of no packages, thinking about the future and assuming for now that only bookworm will have that package.
Does that make sense?
If so, then this is what we'd want:
| 'Debian' => $facts['os']['distro']['codename'] ? { 'bookworm' => ['cgroupfs-mount',], 'trixie' => [] }, | |
| 'Debian' => $facts['os']['distro']['codename'] ? { | |
| 'bookworm' => ['cgroupfs-mount',], | |
| default => [] | |
| }, |
How does that sound?
There was a problem hiding this comment.
As i don't see the cgroupfs-mount package available in sid (ref), i suggest we keep a default of no packages, thinking about the future and assuming for now that only bookworm will have that package.
i just implemented something like that, even though a bit different than in my comment above, to capture the current state of package availability in Debian, so:
- if codename is bullseye (current oldstable) or bookworm (current stable), we require the package
- else, we don't.
Note that in some days bullseye will become oldoldstable, bookworm will become oldstable, and trixie will become stable, so the proposed code should be good at least for the life of the next stable release, that is, a couple of years.
i'm actually unsure about whether we should introduce the requirement for bullseye, as it was not there before and will impact any bullseye installation that uses this module.
There was a problem hiding this comment.
in #1031, i just dropped the package entirely, and replaced it with apparmor which is necessary to run docker, even in bookworm.
not sure what the supported debian releases are in this module, but i would suggest dropping bullseye anyways.
|
Hello, we could really use this change for Debian 13, do you have any news about this PR ? Thank you. |
|
+1, I had to set |
|
@zen-fu, Please rebase this branch. |
At this moment, the `cgroupfs-mount` package only exists in Debian up to Bookworm, so we must not require that package for newer releases. Fixes puppetlabs#1023
done! |
|
@charlyforot Any progress on this? |
9 participants
Summary
remove dependency on cgroupfs-mount for Debian trixie, because that package isn't available in that release.
Related Issues (if any)
Fixes #1023
Checklist
puppet apply)