Skip to content

Fix up rspec deprecation warnings.#166

Merged
tphoney merged 1 commit intopuppetlabs:masterfrom
alex-harvey-z3q:fix_rspec_deprecation_warnings
Apr 13, 2016
Merged

Fix up rspec deprecation warnings.#166
tphoney merged 1 commit intopuppetlabs:masterfrom
alex-harvey-z3q:fix_rspec_deprecation_warnings

Conversation

@alex-harvey-z3q
Copy link
Copy Markdown
Contributor

No description provided.

@tphoney tphoney closed this Apr 13, 2016
@tphoney tphoney reopened this Apr 13, 2016
@tphoney
Copy link
Copy Markdown
Contributor

tphoney commented Apr 13, 2016

@alexharv074 apologies for the close and reopen. accidental click

@tphoney
Copy link
Copy Markdown
Contributor

tphoney commented Apr 13, 2016

Great work !!

@tphoney tphoney merged commit 3fa562a into puppetlabs:master Apr 13, 2016
@alex-harvey-z3q
Copy link
Copy Markdown
Contributor Author

@tphoney Not sure if you noticed but the build was red before the merge.

  incompatible OSs
    is_expected.to fail on windows 8.1 (FAILED - 1)
    is_expected.to fail on Darwin 13.3.0 (FAILED - 2)
    is_expected.to fail on AIX 7100-02-00-000 (FAILED - 3)
    is_expected.to fail on AIX 6100-07-04-1216 (FAILED - 4)
    is_expected.to fail on AIX 5300-12-01-1016 (FAILED - 5)

Was that something that was already broken? I don't see how my change would have caused that.

@tphoney
Copy link
Copy Markdown
Contributor

tphoney commented Apr 13, 2016

I sure did :) #168 will fix this issue. Thanks for being vigilant. @alexharv074

@alex-harvey-z3q
Copy link
Copy Markdown
Contributor Author

Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants