Allow targeting specific major/minor Oracle JDK versions#192
Merged
hunner merged 2 commits intopuppetlabs:masterfrom Oct 7, 2016
Merged
Allow targeting specific major/minor Oracle JDK versions#192hunner merged 2 commits intopuppetlabs:masterfrom
hunner merged 2 commits intopuppetlabs:masterfrom
Conversation
Expose two new parameters 'version_major' and 'version_minor' to allow users targeting specific Oracle JDK versions. Signed-off-by: Gregor Zurowski <gregor@zurowski.org>
Signed-off-by: Gregor Zurowski <gregor@zurowski.org>
|
Hi, I just noticed that the documentation is not giving the correct parameters names:
It's kinda misleading ;-) Hope this helps! |
Contributor
Author
|
Good point, thanks for pointing this out, @nicolasbrechet. I have created a new PR for fixing the documentation: #196 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose two new parameters 'version_major' and 'version_minor' to allow users targeting specific Oracle JDK versions.