Fixed search for matching line with java version#260
Closed
shuebnersr wants to merge 4 commits intopuppetlabs:masterfrom
Closed
Fixed search for matching line with java version#260shuebnersr wants to merge 4 commits intopuppetlabs:masterfrom
shuebnersr wants to merge 4 commits intopuppetlabs:masterfrom
Conversation
do not just try to read java version from first line, but search for the matching line from java output
…when_java_not_installed Fact1760 test for java version when java not installed
Use value of variable instead of return statement Extended unit test for checking handling of JAVA_TOOL_OPTIONS
Contributor
Author
|
Code improved, CI checks now succeed. Pull request #257 has updated itself, so no need to create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use value of variable instead of return statement
Extended unit test for checking handling of JAVA_TOOL_OPTIONS