Added support for Amazon linux#29
Merged
brettporter merged 2 commits intopuppetlabs:masterfrom Jul 13, 2013
Merged
Conversation
Contributor
|
Thanks - some overlap with #17 - will take a look. |
Contributor
Author
|
Hi @brettporter , Yeah I saw #17, but since that was submitted there was a version comparison check added with Red Hat / CentOS 6.3 that forces the version of java down to 1.6.0 since Amazon Linux reports its release as version 3. # facter | grep -i -e ^o
operatingsystem => Amazon
operatingsystemmajrelease => 3
operatingsystemrelease => 3.4.43-43.43.amzn1.x86_64
osfamily => RedHatHere's an example using the updated tests with asserts dependent on java 1.7.0: /Users/martin/.rvm/rubies/ruby-1.9.3-p385/bin/ruby -S rspec spec/classes/java_spec.rb --color
expected that the catalogue would contain Package[java] with name set to `"java-1.7.0-openjdk-devel"` but it is set to `"java-1.6.0-openjdk-devel"` in the catalogue
./spec/classes/java_spec.rb:33:in `block (3 levels) in <top (required)>'
expected that the catalogue would contain Package[java] with name set to `"java-1.7.0-openjdk"` but it is set to `"java-1.6.0-openjdk"` in the catalogue
./spec/classes/java_spec.rb:39:in `block (3 levels) in <top (required)>'
7 examples, 2 failures, 5 passedCheers |
Contributor
|
Thanks, good catch! |
brettporter
added a commit
that referenced
this pull request
Jul 13, 2013
Added support for Amazon linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Amazon linux version 3 with Facter 1.7.x.
Ref: http://projects.puppetlabs.com/issues/15792
Also updated .gitignore to prevent my IDE messing up the source tree.
Cheers
-Martin