Skip to content

Optimized code for making java::oracle atomic. Fixes MODULES-8085#330

Merged
david22swan merged 2 commits intopuppetlabs:masterfrom
dodevops:MODULES-8085
Oct 12, 2018
Merged

Optimized code for making java::oracle atomic. Fixes MODULES-8085#330
david22swan merged 2 commits intopuppetlabs:masterfrom
dodevops:MODULES-8085

Conversation

@dploeger
Copy link
Copy Markdown
Contributor

No description provided.

@david22swan
Copy link
Copy Markdown
Member

@dploeger Your code is currently failing a syntax check, other than that the change looks good to me.

Offenses:
spec/defines/oracle_spec.rb:186:13: C: Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
            ensure: 'present',
            ^^^^^^^^^^^^^^^^^
spec/defines/oracle_spec.rb:279:13: C: Layout/IndentHash: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
            ensure: 'present',
            ^^^^^^^^^^^^^^^^^

@dploeger
Copy link
Copy Markdown
Contributor Author

@david22swan Oh, right. Sorry. Fixed that.

@david22swan
Copy link
Copy Markdown
Member

screen shot 2018-10-12 at 2 47 17 pm

@david22swan david22swan merged commit 61ffb4b into puppetlabs:master Oct 12, 2018
@dploeger dploeger deleted the MODULES-8085 branch October 15, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants