Closed
Conversation
sheenaajay
reviewed
Jul 26, 2019
Rakefile
Outdated
| raise "Set CHANGELOG_GITHUB_TOKEN environment variable eg 'export CHANGELOG_GITHUB_TOKEN=valid_token_here'" if Rake.application.top_level_tasks.include? "changelog" and ENV['CHANGELOG_GITHUB_TOKEN'].nil? | ||
| config.user = "#{changelog_user}" | ||
| config.project = "#{changelog_project}" | ||
| config.since_tag = '2.4.0' |
Contributor
There was a problem hiding this comment.
Hi @RandomNoun7 Changes looks good.
since_tag can be updated in the .sync.yaml file and we can run pdk update.
Not sure if we need to update since_tag since the module has been using the Changelog generator from release 3.0.0.
Let me also try to run.
Contributor
|
Hi @RandomNoun7, I think we should get this PR merged #372 and do a major release |
Contributor
|
Sorry @RandomNoun7 you will need to re-run this. I merged @carabasdaniel PR. For the oracle work. Thanks for your patience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.