(MODULES-10935) - Switch legacy operatingsystem fact to modern kernel one#461
Merged
pmcmaw merged 2 commits intopuppetlabs:mainfrom Feb 17, 2021
Merged
(MODULES-10935) - Switch legacy operatingsystem fact to modern kernel one#461pmcmaw merged 2 commits intopuppetlabs:mainfrom
pmcmaw merged 2 commits intopuppetlabs:mainfrom
Conversation
Contributor
|
Hey @rjd1 I would like to thank you for your PR, however it is causing failures in the unit tests, if you would have time to address this I would be more than happy to get your change merged. Thank you for taking the time to submit this. :-) |
Contributor
Author
|
Hi @pmcmaw I've updated the corresponding spec file to reflect the fact change. It looks like all checks are passing now. Thanks! |
Contributor
|
Thanks for that @rjd1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.