(CONT-173) - Updating deprecated facter instances#531
Merged
Conversation
jordanbreen28
force-pushed
the
cont-173/main/update_deprecated_facter
branch
from
df10faa to
9bec045
Compare
jordanbreen28
force-pushed
the
cont-173/main/update_deprecated_facter
branch
3 times, most recently
from
2b72c4a to
be33af6
Compare
Prior to this PR, this module contained instances of Facter::Util::Resolution.exec and Facter::Util::Resolution.which, which are deprecated. This PR aims to replace these exec helpers with their supported Facter::Core::Execution counterparts. This PR: - Replaces all Facter::Util::Resolution instances with corresponding Facter::Core::Execution exec helpers Fixed Spec Test Failures
jordanbreen28
force-pushed
the
cont-173/main/update_deprecated_facter
branch
from
be33af6 to
19afda2
Compare
chelnak
approved these changes
Oct 20, 2022
Contributor
chelnak
left a comment
chelnak
left a comment
There was a problem hiding this comment.
Changes look good and it makes sense to refactor the fact definition.
We should keep an eye out for issues to just to be safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, this module contained instances of Facter::Util::Resolution.exec and Facter::Util::Resolution.which, which are deprecated. This PR aims to replace these exec helpers with their supported Facter::Core::Execution counterparts.
This PR: