Fix shell_escape of unless command

[traylenator]

A bug was introduced in 74ea1de .

It resulted in an error:

Error: /Stage[main]/Java::Config/Exec[create-java-alternatives]: Could not evaluate:
   Could not find command 'alternatives\'

The effective exec was:

exec{'create-java-alternatives':
  path    => '/usr/bin:/usr/sbin:/bin:/sbi
  command => ['alternatives', '--install', '/usr/bin/java', 'java', $java::use_java_alternative_path, '20000'],
  unless  => shell_escape("alternatives --display java | grep -q $java::use_java_alternative_path}"),
}

This errors since the spaces inside the shell_escape are also escaped to \ .

This patch only shell_escapes the external supplied string java::java_alternative_path which was I expect the object the exercise.

Configuration to trigger the bug, but it should not be hard.

class{'java':
 distribution          => 'jdk',
 java_alternative      => '/usr/lib/jvm/java-11-openjdk/bin/java',
 java_alternative_path => '/usr/lib/jvm/java-11-openjdk/bin/java',
 java_home             => '/usr/lib/jvm/java-11-openjdk/',
 package               => 'java-11-openjdk-devel',
 version               => 'present',
}

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

java::config is a class

that may have no external impact to Forge modules.

This module is declared in 79 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[traylenator]

@treydock for info 9.0.1 is broken your keycloak module which you don't support yet :-)

[traylenator]

Avoiding this completely using https://forge.puppet.com/modules/puppet/alternatives would be a good idea.

[traylenator]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

CLA has be signed for me on behalf of CERN IT.

[david22swan]

LGTM
Thanks for catching this