Skip to content

Add alternative support for RedHat#61

Merged
underscorgan merged 1 commit intopuppetlabs:masterfrom
convectionlabs:master
Nov 12, 2014
Merged

Add alternative support for RedHat#61
underscorgan merged 1 commit intopuppetlabs:masterfrom
convectionlabs:master

Conversation

@rdrgmnzs
Copy link
Copy Markdown

No description provided.

@puppetcla
Copy link
Copy Markdown

Waiting for CLA signature by @dstockman

@dstockman - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

@dstockman
Copy link
Copy Markdown
Contributor

I accepted the CLA. All yours!

@puppetcla
Copy link
Copy Markdown

CLA signed by all contributors.

@rdrgmnzs
Copy link
Copy Markdown
Author

dstockman, thanks. The patch was great. Happy I didn't have to write my own.

@dstockman
Copy link
Copy Markdown
Contributor

Is there any chance on getting this merged? Thanks!

@igalic
Copy link
Copy Markdown

igalic commented Sep 30, 2014

that might help put the metadata.json

  "operatingsystem_support": [
    {
      "operatingsystem": "RedHat",
      "operatingsystemrelease": [
        "5",
        "6",
        "7"
      ]
    },

closer to the truth ;)

@igalic
Copy link
Copy Markdown

igalic commented Sep 30, 2014

@hunner ping ^

@prizos
Copy link
Copy Markdown

prizos commented Oct 22, 2014

ping, can we please get this merged ?

@rdrgmnzs
Copy link
Copy Markdown
Author

rdrgmnzs commented Nov 5, 2014

Any news on this pull requests status?

@igalic
Copy link
Copy Markdown

igalic commented Nov 7, 2014

ping @mhaskel

underscorgan pushed a commit that referenced this pull request Nov 12, 2014
Add alternative support for RedHat
@underscorgan underscorgan merged commit b00b4b8 into puppetlabs:master Nov 12, 2014
@underscorgan
Copy link
Copy Markdown
Contributor

Thanks @brdude

@underscorgan
Copy link
Copy Markdown
Contributor

@brdude @dstockman sorry for merging this prematurely. This PR needs documentation updates, should have test updates to make sure this actually works, and I'd like to see the updates go into java::params before this is actually complete enough to merge. Can you reopen this pull request or open a new one with these updates?

@rdrgmnzs
Copy link
Copy Markdown
Author

@mhaskel #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants