Skip to content

(IAC-746) - Add ubuntu 20.04 support#318

Merged
sanfrancrisko merged 1 commit intomasterfrom
pdksync_IAC-746
May 29, 2020
Merged

(IAC-746) - Add ubuntu 20.04 support#318
sanfrancrisko merged 1 commit intomasterfrom
pdksync_IAC-746

Conversation

@david22swan
Copy link
Copy Markdown
Member

IAC-746
pdk version: 1.17.0

@david22swan david22swan requested a review from a team as a code owner May 20, 2020 10:55
@david22swan david22swan changed the title pdksync - IAC-746 (IAC-746) - Add ubuntu 20.04 support May 20, 2020
@david22swan david22swan force-pushed the pdksync_IAC-746 branch 2 times, most recently from a92d075 to 53dfd37 Compare May 20, 2020 14:47
@david22swan
Copy link
Copy Markdown
Member Author

Failure should resolve once Java pr is merged.

@david22swan
Copy link
Copy Markdown
Member Author

Test's won't pass till puppetlabs/puppetlabs-java#428 is merged and released

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 29, 2020

Codecov Report

Merging #318 into master will increase coverage by 6.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   61.85%   68.14%   +6.29%     
==========================================
  Files           2        2              
  Lines         270      270              
==========================================
+ Hits          167      184      +17     
+ Misses        103       86      -17     
Impacted Files Coverage Δ
lib/puppet/provider/java_ks/keytool.rb 56.98% <0.00%> (+9.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d476f9f...e84204a. Read the comment docs.

@sanfrancrisko sanfrancrisko merged commit 3704e79 into master May 29, 2020
@sanfrancrisko sanfrancrisko deleted the pdksync_IAC-746 branch May 29, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants