Clean up acceptance tests to minimize the spec helper#1401
Open
ekohl wants to merge 4 commits intopuppetlabs:mainfrom
Open
Clean up acceptance tests to minimize the spec helper#1401ekohl wants to merge 4 commits intopuppetlabs:mainfrom
ekohl wants to merge 4 commits intopuppetlabs:mainfrom
Conversation
Collaborator
|
@ekohl can you rebase this one? |
This is a pattern we use in Vox Pupuli. In fact, voxpupuli-acceptance does this if it detects the file automatically. The biggest benefit is that editors and linters can work on the file, which increases quality.
ekohl
force-pushed
the
clean-up-acceptance-tests
branch
from
b67727f to
da7f548
Compare
ekohl
requested review from
SimonHoenscheid,
alexjfisher,
bastelfreak,
deric and
smortex
as code owners
Collaborator
|
mhm can you apply some rubocop autofix magic? |
Ruby can do this natively for a while using <<~
ekohl
force-pushed
the
clean-up-acceptance-tests
branch
from
da7f548 to
8090f54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During cfgmgmtcamp it was mentioned that Puppet may want to switch back from Litmus to Beaker. This takes some small steps by reducing the size of
spec_helper_acceptance_local.rb, which in my experience is always a good step towards alignment. Even if the switch doesn't happen, reducing local spec helpers is always good.I'm going to rely on CI to make sure this is valid.