Skip to content

Fix woman and man paths#85

Closed
Grimpper wants to merge 2 commits intopurcell:masterfrom
Grimpper:fix-manpaths
Closed

Fix woman and man paths#85
Grimpper wants to merge 2 commits intopurcell:masterfrom
Grimpper:fix-manpaths

Conversation

@Grimpper
Copy link
Copy Markdown
Contributor

Hello. The following patches fixes the Emacs woman and man procedures not inheriting the envrc environment.

The fix for woman is similar to the one done for the info-display-manual procedure, where we needed to flush it's cache.

On the other hand, the man command was a bit more tricky to solve. The issue was that the completing-read function that man uses, Man-completion-table, needs to inherit the environment. This can be solved advising it with envrc-propagate-environment, but since it's invoked from the minibuffer, envrc-mode mode will be disabled; and the wrapper will not inject the environment. In order to solve it, we need to remove the logic that prevents envrc-global-mode to enable envrc-mode in the minibuffer.

I hope this helps!

@Grimpper Grimpper changed the title Fix manpaths Fix woman and man paths Jul 12, 2024
@Grimpper
Copy link
Copy Markdown
Contributor Author

Closing this PR in favor of this 2 which allow to merge each change individually:

@Grimpper Grimpper closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant