Skip to content

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez
Copy link
Contributor Author

This one seems blocked by spec not being updated yet. Not sure how much that will affect us yet.

@thomashoneyman
Copy link
Contributor

We can migrate this to use assert instead of spec in order to avoid having dependencies outside contrib:

https://github.com/purescript-contrib/purescript-options/blob/main/test/Test/Main.purs

@kl0tl
Copy link
Contributor

kl0tl commented Dec 3, 2020

Should #30 be part of this pull request or merged afterwards?

@thomashoneyman
Copy link
Contributor

I can merge #30 as soon as this is merged in.

@JordanMartinez
Copy link
Contributor Author

CI passes now.

@thomashoneyman thomashoneyman merged commit 7c38033 into purescript-contrib:main Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants