-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Description
Here are some changes that I think could be beneficial for this library:
- Put client side and server side functions in separate modules - on js level there are
react-domandreact-dom/servermodules, I think it makes sense to have the same kind of separation on purescript level, too. - Make
renderToStringandrenderToStaticMarkupeffectful - these functions can have side effects, here you can find an example (callingcollect, thentoString, thenrenderToStringwill result incssbeing an empty string) - Switch to
spagoas a better alternative topsc-package.
Don't know about the last one, but first two are definitely breaking changes. What do you think about it? If you are ok with these changes, I will make a PR.
Metadata
Metadata
Assignees
Labels
No labels