This repository was archived by the owner on Oct 4, 2020. It is now read-only.
Add Blob.slice #126
Merged
Add Blob.slice #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
reviewed
Sep 27, 2017
src/DOM/File/Blob.purs
Outdated
| -- | data in the specified range of bytes of the source Blob, by setting . | ||
| slice ∷ MediaType -> StartByte -> EndByte -> Blob -> Blob | ||
| slice mediaType (StartByte start) (EndByte end) blob = | ||
| _slice blob start end (unwrap mediaType) |
Member
There was a problem hiding this comment.
We could just make this the FFI function directly - there's no need to unwrap any of the newtypes since they have no runtime representation.
Would just need to rearrange the FFI function's argument to match the ones we want :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments are adopted from https://developer.mozilla.org/en-US/docs/Web/API/Blob/slice
fix #125