Skip to content

Update to purescript 0.11 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wires wants to merge 5 commits into from
Closed

Update to purescript 0.11 #18

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
551f2eb
Update to purescript 0.11
wires Apr 2, 2017
738f469
Updated build tool versions
wires Apr 2, 2017
ff10db5
Removed unneeded import
wires Apr 2, 2017
536c767
Update to new curried fat-arrow syntax
wires Apr 3, 2017
47e12bb
Arguments in pulp now require `--` in front
wires Apr 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
"url": "git://github.com/purescript-node/purescript-node-buffer"
},
"dependencies": {
"purescript-eff": "^2.0.0",
"purescript-maybe": "^2.0.0"
"purescript-eff": "^3.0.0",
"purescript-maybe": "^3.0.0"
},
"devDependencies": {
"purescript-assert": "^2.0.0",
"purescript-console": "^2.0.0",
"purescript-foldable-traversable": "^2.0.0"
"purescript-assert": "^3.0.0",
"purescript-console": "^3.0.0",
"purescript-foldable-traversable": "^3.0.0"
}
}
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
"build": "pulp build --censor-lib --strict"
Copy link
Contributor

@paf31 paf31 Apr 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to separate arguments with -- now:

pulp build -- --censor-lib --strict

Copy link
Author

@wires wires Apr 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum.., tried this before but it didn't work, pushed anyway but build is still failing.

I'm having problems building this locally, seems to be related to pulp (FWIW, I don't like this build tool, using my own Makefiles for my projects).

},
"devDependencies": {
"pulp": "^9.0.1",
"purescript-psa": "^0.3.9",
"purescript": "^0.10.1",
"rimraf": "^2.5.4"
"pulp": "^10.0.4",
"purescript-psa": "^0.5.0",
"purescript": "^0.11.1",
"rimraf": "^2.6.1"
}
}
6 changes: 3 additions & 3 deletions src/Node/Buffer.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module Node.Buffer
) where

import Prelude
import Control.Monad.Eff (Eff)
import Control.Monad.Eff (Eff, kind Effect)
import Data.Maybe (Maybe(..))
import Node.Encoding (Encoding, encodingToNode)

Expand All @@ -35,15 +35,15 @@ type Octet = Int
type Offset = Int

-- | An instance of Node's Buffer class.
foreign import data Buffer :: *
foreign import data Buffer :: Type

instance showBuffer :: Show Buffer where
show = showImpl

foreign import showImpl :: Buffer -> String

-- | Effect for buffer creation, reading, or writing.
foreign import data BUFFER :: !
foreign import data BUFFER :: Effect

-- | Enumeration of the numeric types that can be written to a buffer.
data BufferValueType
Expand Down