Skip to content

Add stream functions #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hdgarrood merged 2 commits into from
Dec 18, 2015
Merged

Add stream functions #26

hdgarrood merged 2 commits into from
Dec 18, 2015

Conversation

@hdgarrood
Copy link
Member

@hdgarrood hdgarrood commented Dec 14, 2015

Fixes #13

@hdgarrood
Copy link
Member Author

hdgarrood commented Dec 14, 2015

Also, the unsafeRequireFS stuff is because I want to make Node.FS.Internal the only module that has FFI implementations. Given that handleCallbackImpl is the same in both Sync and Async, we should put that into Node.FS.Internal too, and then we can get rid of all the other FFI files. :) But I'll do that later

@hdgarrood
Copy link
Member Author

hdgarrood commented Dec 15, 2015

Eh, I'll just do it now.

hdgarrood added a commit that referenced this pull request Dec 18, 2015
@hdgarrood
Merge pull request #26 from purescript-node/add-stream-fns
b482169 
Add stream functions
@hdgarrood hdgarrood merged commit b482169 into master Dec 18, 2015
@hdgarrood hdgarrood deleted the add-stream-fns branch December 18, 2015 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hdgarrood