Skip to content

Remove redundant StatsObj methods #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pete-murphy wants to merge 1 commit into from
Closed

Remove redundant StatsObj methods #72

pete-murphy wants to merge 1 commit into from

Conversation

@pete-murphy
Copy link

@pete-murphy pete-murphy commented Nov 4, 2022 •
edited
Loading

Resolves #71

Description of the change

The StatsObj methods are not pure (require this context be preserved) and are redundant anyways (there are standalone functions Stats -> Boolean for each method). This deletes them from StatsObj.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@pete-murphy pete-murphy marked this pull request as ready for review November 4, 2022 20:37
@JordanMartinez
Copy link
Contributor

JordanMartinez commented Jul 14, 2023

Superceded by #76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove redundant/impure StatsObj Fn0 methods

2 participants

@pete-murphy @JordanMartinez