Add ElementCSSInlineStyle and CSSStyleDeclaration #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singpolyma
force-pushed
the
cssinlinestyle
branch
from
aa2646b to
982fe2d
Compare
garyb
requested changes
Sep 25, 2020
Member
garyb
left a comment
garyb
left a comment
There was a problem hiding this comment.
Thanks! Looks great aside from one minor thing with the coercion here.
|
|
||
| foreign import style :: ElementCSSInlineStyle -> Effect CSSStyleDeclaration | ||
|
|
||
| fromElement :: Element -> ElementCSSInlineStyle |
Member
There was a problem hiding this comment.
I think this should be fromHTMLElement and using Web.HTML.HTMLElement (HTMLElement) since the spec IDL just has:
HTMLElement implements ElementCSSInlineStyle;
SVGElement implements ElementCSSInlineStyle;
(No need to worry about the SVG case just now, there isn't a web-svg library).
Element is the parent interface so both of these, but also applies to XML documents I think, where this wouldn't apply.
singpolyma
force-pushed
the
cssinlinestyle
branch
from
982fe2d to
71d994d
Compare
This is a mixin for HTMLElement and others from CSSOM to add the style attribute.
singpolyma
force-pushed
the
cssinlinestyle
branch
from
71d994d to
173f4fd
Compare
Adds all needed methods. There are also named properties for every CSS property, but those are redundant with getPropertyValue / setProperty.
singpolyma
force-pushed
the
cssinlinestyle
branch
from
173f4fd to
1df8cd1
Compare
Member
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both needed so one can use
el.stylefor dynamically styling DOM Element.