Add support for ShadowRoot API #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyb
reviewed
Jan 6, 2021
src/Web/DOM/ShadowRoot.purs
Outdated
Comment on lines
24
to
25
| attachShadow :: ShadowRootMode -> Element -> Effect ShadowRoot | ||
| attachShadow = _attachShadow <<< modeToProps |
Member
There was a problem hiding this comment.
I'd suggest this belongs in Web.DOM.Element, since the member is part of the Element interface.
Contributor
Author
There was a problem hiding this comment.
Hi Gary, thank you for the suggestion. I have moved the function and related stuff to Web.DOM.Element and updated it to accept an argument of type ShadowRootInit type as per the specs.
JordanMartinez
approved these changes
Jan 7, 2021
Contributor
Author
|
Hello! Please let me know if there's any other change you would suggest, or if the scope of this PR is not relevant for some reason! Cheers |
thomashoneyman
approved these changes
Jan 13, 2021
sigma-andex
pushed a commit
to working-group-purescript-es/purescript-web-dom
that referenced
this pull request
Apr 14, 2022
Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic implementation of the shadow-root functionality, as per DOM standard.
The function
attachShadowis a binding to the corresponding DOM JavaScript function describedon MDN.