Incorporate getting-started content from book #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
May 20, 2020
Collaborator
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Thanks! Just a few comments.
Contributor
Author
|
Thanks for the thorough review. Applied feedback in latest push. |
hdgarrood
approved these changes
May 20, 2020
Collaborator
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Thanks! I'll merge this in a day or so unless anyone else objects.
Collaborator
|
Also, it's not a problem now, but would you mind pushing new commits rather than rebasing and force-pushing in the future? It's easier to review what's changed since the last time I looked that way, and GitHub already makes it easy to squash when it comes to merging. |
Contributor
Author
|
Yes, I agree. I believe this one was an incremental commit though. |
Collaborator
|
🤦 so it was, I just don't know how to use the GitHub UI apparently. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an accompanying PR (purescript-contrib/purescript-book#144) in the book repo to point to this guide as a first step in environment setup.
More discussion about this change can be read in: purescript-contrib/purescript-book#93
This address #309 in this repo.