Skip to content

Use Char's top/bottom, not Int's #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JordanMartinez merged 2 commits into from
Aug 15, 2022
Merged

Use Char's top/bottom, not Int's #55

JordanMartinez merged 2 commits into from
Aug 15, 2022

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Aug 15, 2022

Description of the change

Fixes #50. I came across this bug again today, which was introduced in #14:

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez merged commit 08c3fe8 into purescript:master Aug 15, 2022
@JordanMartinez JordanMartinez deleted the jam/fix-char-enum branch August 15, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garyb garyb garyb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

charToEnum implementation is wrong

2 participants

@JordanMartinez @garyb