Skip to content

Drop MonadZero instance #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JordanMartinez merged 4 commits into from
Mar 16, 2022
Merged

Drop MonadZero instance #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44a9695
Drop MonadZero instance
JordanMartinez Feb 15, 2022
9c962fd
Drop udw censoring
JordanMartinez Feb 15, 2022
26c7e68
Merge remote-tracking branch 'origin/master' into dropMonadZero
JordanMartinez Mar 16, 2022
e7db34a
Added changelog entry
JordanMartinez Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Notable changes to this project are documented in this file. The format is based

Breaking changes:
- Update project and deps to PureScript v0.15.0 (#36 by @JordanMartinez)
- Drop deprecated `MonadZero` instance (#35 by @JordanMartinez)

New features:

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"private": true,
"scripts": {
"clean": "rimraf output && rimraf .pulp-cache",
"build": "pulp build -- --censor-lib --strict --censor-codes='UserDefinedWarning'",
"build": "pulp build -- --censor-lib --strict",
"test": "pulp test"
},
"devDependencies": {
Expand Down
4 changes: 1 addition & 3 deletions src/Data/Functor/App.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import Control.Apply (lift2)
import Control.Comonad (class Comonad)
import Control.Extend (class Extend)
import Control.Lazy (class Lazy)
import Control.MonadPlus (class MonadZero, class MonadPlus)
import Control.MonadPlus (class MonadPlus)
import Control.Plus (class Plus)
import Data.Eq (class Eq1)
import Data.Newtype (class Newtype)
Expand Down Expand Up @@ -42,8 +42,6 @@ instance semigroupApp :: (Apply f, Semigroup a) => Semigroup (App f a) where
instance monoidApp :: (Applicative f, Monoid a) => Monoid (App f a) where
mempty = App (pure mempty)

instance monadZeroApp :: MonadZero f => MonadZero (App f)

derive newtype instance functorApp :: Functor f => Functor (App f)
derive newtype instance applyApp :: Apply f => Apply (App f)
derive newtype instance applicativeApp :: Applicative f => Applicative (App f)
Expand Down