-
Notifications
You must be signed in to change notification settings - Fork 50
Closed
Labels
type: enhancementA new feature or addition.A new feature or addition.
Description
Proposing we modify the newly-added (in #182) groupAllBy from:
groupAllBy :: forall a. Ord a => (a -> a -> Boolean) -> List a -> List (NEL.NonEmptyList a)to:
groupAllBy :: forall a. (a -> a -> Ordering) -> List a -> List (NEL.NonEmptyList a)The existing version can lead to undesired output where the Ord instance fights against your clustering rule.
The new version also more closely matches the pattern set by these other functions:
sortBy :: forall a. (a -> a -> Ordering) -> List a -> List a
-- (the below is true after #179)
nubBy :: forall a. (a -> a -> Ordering) -> List a -> List aIf we do this before 0.14, we don't even have to worry about an API bump.
@kl0tl for review.
Metadata
Metadata
Assignees
Labels
type: enhancementA new feature or addition.A new feature or addition.